Skip to content

chore(workflow): add validation logic for deploy-demo and deploy-documentation workflows #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(workflow): add validation logic for deploy-demo and deploy-documentation workflows #5344

wants to merge 2 commits into from

Conversation

alionazherdetska
Copy link
Contributor

@alionazherdetska alionazherdetska commented Apr 24, 2025 •
edited
Loading

Ticket: #5191

📄 Description

Enhance deployment workflow security by:

  • Validating issue numbers and netlify configs
  • Sanitizing all user inputs before use
  • Using safer scripting methods

🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@alionazherdetska alionazherdetska requested a review from a team as a code owner April 24, 2025 17:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 256cb8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alionazherdetska alionazherdetska requested review from gfellerph and removed request for oliverschuerch April 24, 2025 17:40
@alionazherdetska alionazherdetska mentioned this pull request Apr 24, 2025
Closed
@vercel Vercel
Copy link

vercel bot commented May 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2025 6:38am

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gfellerph gfellerph requested review from oliverschuerch and alizedebray and removed request for gfellerph May 8, 2025 12:50
@alionazherdetska alionazherdetska linked an issue May 10, 2025 that may be closed by this pull request
Fix codeql findings #5191
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch Awaiting requested review from oliverschuerch

@alizedebray alizedebray Awaiting requested review from alizedebray

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix codeql findings
1 participant
@alionazherdetska